introducing commit input bus #127
Merged
+869
−568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chengxuan Xing <[email protected]>
…buses Signed-off-by: Chengxuan Xing <[email protected]>
jimthematrix
approved these changes
Apr 14, 2025
Contributor
|
Added approval. would be good to add explanation as to why the KYC solidity verification parameters have changed. |
Contributor
Author
|
I can't tell why the KYC solidity verification parameters have changed while the sol verifier of all the other
|
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Contributor
|
confirming that the updates in the anon_nullifier_kyc verifier contracts are also reproduced on a separate laptop (mine). so keeping them for the PR. also merged from main and fixed the burn circuits with buses |
Signed-off-by: Jim Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing an internal bus CommitInputs, the external inputs of the top level circuits have not been updated, therefore, no solidity or circuit test files needed to be updated.
Also